Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #345: introduce data-source for hosts in cluster #376

Merged
1 commit merged into from
May 18, 2022

Conversation

eslutsky
Copy link
Collaborator

@eslutsky eslutsky commented May 17, 2022

Please describe the change you are making

This PR fixes #345 and adds the ability to list hosts by cluster ID.

Are you the owner of the code you are sending in, or do you have permission of the owner?

Yes

The code will be published under the BSD 3 clause license. Have you read and understood this license?

Yes

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow New resource: ovirt_datacenter #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@eslutsky eslutsky changed the title fixes #345: introduce data-source for hosts in cluster Fixes #345: introduce data-source for hosts in cluster May 17, 2022
@eslutsky eslutsky force-pushed the 345-data-source-cluster-hosts branch 3 times, most recently from 47b8fdf to ebcef6f Compare May 17, 2022 11:31
@eslutsky eslutsky marked this pull request as ready for review May 17, 2022 11:40
@eslutsky eslutsky requested a review from a user May 17, 2022 11:49
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you add examples to the examples directory?

@eslutsky eslutsky force-pushed the 345-data-source-cluster-hosts branch 2 times, most recently from d32067d to 0a8ac77 Compare May 17, 2022 13:50
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eslutsky you merged instead of a rebase. Could you rebase please?

@eslutsky eslutsky force-pushed the 345-data-source-cluster-hosts branch from b52b855 to 13c834a Compare May 17, 2022 14:32
@eslutsky
Copy link
Collaborator Author

@eslutsky you merged instead of a rebase. Could you rebase please?

done

@eslutsky eslutsky requested a review from a user May 17, 2022 14:33
@eslutsky eslutsky requested a review from a user May 17, 2022 20:22
@eslutsky eslutsky force-pushed the 345-data-source-cluster-hosts branch from 13c834a to dc4c167 Compare May 18, 2022 07:42
@ghost ghost merged commit 47a79fb into oVirt:main May 18, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the ovirt_cluster_hosts data source
2 participants